diff --git a/CHANGELOG.md b/CHANGELOG.md index b359d92cc..76c13a856 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,18 @@ # Changelog +## [1.0.8-rc37] - unstable + +### Added + +* [PostIt] Replace the persistent status bar with a global notification service using ephemeral toasts for info/success and dismissible modal alerts for warnings/errors. + +* [PostIt] Refactor rendez-vous address editing around a dedicated physical-address view model and a dedicated address editor page so the map remains usable without a ScrollViewer and the main command form stays compact on small screens. + +* [PostIt/Administration] Rechercher les utilisateurs côté serveur par login ou nom, par pages de 25 résultats maximum avec navigation précédente/suivante. + +* [PostIt] Telemetry + ## [1.0.8-rc36] - unstable ### Added diff --git a/src/PostIt/PostIt.Android/Services/AndroidBackgroundChatService.cs b/src/PostIt/PostIt.Android/Services/AndroidBackgroundChatService.cs index ddefc4cf3..c2288fd0c 100644 --- a/src/PostIt/PostIt.Android/Services/AndroidBackgroundChatService.cs +++ b/src/PostIt/PostIt.Android/Services/AndroidBackgroundChatService.cs @@ -87,6 +87,7 @@ internal sealed class AndroidBackgroundChatService : IBackgroundChatService { Cancel(epoch); Log.Error("PostIt.Chat", ex.ToString()); + api.QueueExceptionReport(ex, "PostIt.Android.Chat"); try { await AndroidSettings.UpdateAsync(api.Settings, s => s.SetActionStatus(ex.Message, StatusSeverity.Error)) diff --git a/src/PostIt/PostIt.Android/Services/ChatBootReceiver.cs b/src/PostIt/PostIt.Android/Services/ChatBootReceiver.cs index c38d46c0f..7adf97c54 100644 --- a/src/PostIt/PostIt.Android/Services/ChatBootReceiver.cs +++ b/src/PostIt/PostIt.Android/Services/ChatBootReceiver.cs @@ -34,8 +34,11 @@ public sealed class ChatBootReceiver : BroadcastReceiver { Log.Error("PostIt.Chat", "Boot restart rejected: " + ex); if (api is not null) + { + api.QueueExceptionReport(ex, "PostIt.Android.Chat"); AndroidSettings.ReportError(api.Settings, "Android a refuse le redemarrage de la messagerie : " + ex.Message); + } } finally { pending?.Finish(); } }); diff --git a/src/PostIt/PostIt.Android/Services/ChatBootState.cs b/src/PostIt/PostIt.Android/Services/ChatBootState.cs index 160a30781..4943f7843 100644 --- a/src/PostIt/PostIt.Android/Services/ChatBootState.cs +++ b/src/PostIt/PostIt.Android/Services/ChatBootState.cs @@ -30,10 +30,25 @@ internal static class ChatBootState throw new IOException("Impossible d'enregistrer la deconnexion Android."); } - internal static bool CanStart(YavscApiClient api) => - OptedIn && Preferences.GetBoolean("signed-in", false) - && api.Settings.AndroidKeepChatConnected && !api.IsSigningOut && api.HasValidSession - && Identity(api) is { } identity && identity == Preferences.GetString("identity", null); + internal static bool CanStart(YavscApiClient api) + { + if (!OptedIn || !api.Settings.AndroidKeepChatConnected || api.IsSigningOut || !api.HasValidSession) + return false; + + var identity = Identity(api); + if (identity is null) return false; + + var signedIn = Preferences.GetBoolean("signed-in", false); + var storedIdentity = Preferences.GetString("identity", null); + + // A valid refresh-capable session can coexist with stale native prefs + // (for example after app relaunch or an interrupted token renewal). + // Treat missing/lagging prefs as recoverable instead of rejecting the + // start outright, but keep strict identity matching when both values exist. + if (!signedIn && string.IsNullOrEmpty(storedIdentity)) return true; + if (signedIn && !string.IsNullOrEmpty(storedIdentity)) return identity == storedIdentity; + return true; + } internal static string? Identity(YavscApiClient api) { diff --git a/src/PostIt/PostIt.Android/Services/ChatConnectionService.cs b/src/PostIt/PostIt.Android/Services/ChatConnectionService.cs index f887a7d31..7de2f38b1 100644 --- a/src/PostIt/PostIt.Android/Services/ChatConnectionService.cs +++ b/src/PostIt/PostIt.Android/Services/ChatConnectionService.cs @@ -253,6 +253,7 @@ public sealed class ChatConnectionService : Service private void ReportError(Exception ex) { Log.Error("PostIt.Chat", ex.ToString()); + _api?.QueueExceptionReport(ex, "PostIt.Android.Chat"); if (_api is not null) AndroidSettings.ReportError(_api.Settings, ex.Message); } diff --git a/src/PostIt/PostIt.Tests/AdministrationAccessTests.cs b/src/PostIt/PostIt.Tests/AdministrationAccessTests.cs index 429e0ac98..b7805fc53 100644 --- a/src/PostIt/PostIt.Tests/AdministrationAccessTests.cs +++ b/src/PostIt/PostIt.Tests/AdministrationAccessTests.cs @@ -6,6 +6,7 @@ using Avalonia.VisualTree; using PostIt.Services; using PostIt.ViewModels; using PostIt.Views; +using Yavsc.Abstract.Administration; using Yavsc.Abstract.Identity; using Yavsc.Abstract.Resources; using Yavsc.Api.Client; @@ -82,6 +83,42 @@ public class AdministrationAccessTests Assert.DoesNotContain(api.Requests, path => path.EndsWith("/resource-usage/me")); } + [Fact] + public async Task Administration_searches_users_on_the_server_and_pages_results() + { + await using var api = new ProfileTransport("Administrator") { ManyUsers = true }; + var session = new SessionStatusViewModel { Api = api }; + await session.RefreshAsync(); + var vm = new AdministrationPageViewModel(api, api.UsageClient, session); + + await vm.RefreshAsync(); + Assert.Equal(1, vm.UserPage); + Assert.True(vm.HasNextUserPage); + Assert.Equal(25, vm.Users.Count); + Assert.Contains(api.Requests, path => path.Contains( + "/administration/users?page=1&query=", StringComparison.Ordinal)); + + vm.SearchText = "Jean Dupont"; + await vm.SearchUsersCommand.ExecuteAsync(null); + Assert.Equal(1, vm.UserPage); + Assert.False(vm.HasNextUserPage); + Assert.Contains(api.Requests, path => path.Contains( + "/administration/users?page=1&query=Jean", StringComparison.Ordinal)); + + vm.SearchText = ""; + await vm.SearchUsersCommand.ExecuteAsync(null); + Assert.True(vm.HasNextUserPage); + await vm.NextUserPageCommand.ExecuteAsync(null); + Assert.Equal(2, vm.UserPage); + Assert.False(vm.HasNextUserPage); + Assert.Contains(api.Requests, path => path.Contains( + "/administration/users?page=2&query=", StringComparison.Ordinal)); + Assert.False(vm.NextUserPageCommand.CanExecute(null)); + + await vm.PreviousUserPageCommand.ExecuteAsync(null); + Assert.Equal(1, vm.UserPage); + } + [AvaloniaFact] public async Task Administration_displays_both_tabs_and_selected_user_usage() { @@ -232,6 +269,7 @@ public class AdministrationAccessTests public bool FailUsage { get; set; } public bool ExhaustedQuota { get; set; } public bool HideIpAddressInCalls { get; set; } + public bool ManyUsers { get; set; } public ResourceUsageApiClient UsageClient => new(this, Settings.ApiUrl); public ProfileTransport(string role) @@ -278,11 +316,22 @@ public class AdministrationAccessTests }; result = path.EndsWith("/admin") ? new List { usage } : usage; } - else if (path.EndsWith("/users")) + else if (path.Contains("/administration/users", StringComparison.Ordinal)) { if (ExhaustedQuota) throw new HttpRequestException("resource_quota_exceeded", null, System.Net.HttpStatusCode.TooManyRequests); - result = new List { new() { UserId = "alice-id", UserName = "alice" } }; + var matchingQuery = path.Contains("query=Jean", StringComparison.Ordinal); + var page = path.Contains("page=2", StringComparison.Ordinal); + var returnedUsers = !matchingQuery && !page && ManyUsers + ? Enumerable.Range(1, 25).Select(index => new UserInfo + { + UserId = $"alice-id-{index}", UserName = $"alice-{index}" + }).ToList() + : matchingQuery + ? new List { new() { UserId = "jean-id", UserName = "jean", FullName = "Jean Dupont" } } + : page ? new List() + : new List { new() { UserId = "alice-id", UserName = "alice" } }; + result = new AdministrationUserPage(returnedUsers, ManyUsers && !matchingQuery && !page); } else throw new InvalidOperationException($"Unexpected endpoint: {path}"); diff --git a/src/PostIt/PostIt.Tests/HomePageProviderFlowTests.cs b/src/PostIt/PostIt.Tests/HomePageProviderFlowTests.cs index 40922f7ae..84a6afb6e 100644 --- a/src/PostIt/PostIt.Tests/HomePageProviderFlowTests.cs +++ b/src/PostIt/PostIt.Tests/HomePageProviderFlowTests.cs @@ -43,21 +43,7 @@ public class HomePageProviderFlowTests } [Fact] - public void Administration_page_filters_users_by_search_text() - { - var vm = new AdministrationPageViewModel(); - vm.Users.Add(new Yavsc.Abstract.Identity.UserInfo { UserId = "1", UserName = "alice", FullName = "Alice Example" }); - vm.Users.Add(new Yavsc.Abstract.Identity.UserInfo { UserId = "2", UserName = "bob", FullName = "Bob Jones" }); - vm.Users.Add(new Yavsc.Abstract.Identity.UserInfo { UserId = "3", UserName = "carol", FullName = "Carol Smith" }); - - vm.SearchText = "ali"; - - Assert.Single(vm.FilteredUsers); - Assert.Equal("alice", vm.FilteredUsers[0].UserName); - } - - [Fact] - public void Administration_page_filters_users_by_full_name() + public void Administration_search_text_does_not_filter_the_loaded_page_locally() { var vm = new AdministrationPageViewModel(); vm.Users.Add(new Yavsc.Abstract.Identity.UserInfo { UserId = "1", UserName = "alice", FullName = "Alice Example" }); @@ -65,8 +51,8 @@ public class HomePageProviderFlowTests vm.SearchText = "example"; - Assert.Single(vm.FilteredUsers); - Assert.Equal("alice", vm.FilteredUsers[0].UserName); + Assert.Equal(2, vm.Users.Count); + Assert.Equal("example", vm.SearchText); } [Fact] diff --git a/src/PostIt/PostIt.Tests/SettingsLoadTests.cs b/src/PostIt/PostIt.Tests/SettingsLoadTests.cs index 5f3bd765d..415d256fe 100644 --- a/src/PostIt/PostIt.Tests/SettingsLoadTests.cs +++ b/src/PostIt/PostIt.Tests/SettingsLoadTests.cs @@ -175,6 +175,20 @@ public class SettingsLoadTests Assert.Equal("bonjour", roundTrip.SearchText); } + [Fact] + public void Exception_reports_are_disabled_by_default_and_persist_when_enabled() + { + var defaults = new PostIt.ViewModels.Settings(); + Assert.False(defaults.ShareExceptionReports); + + defaults.ShareExceptionReports = true; + var roundTrip = JsonSerializer.Deserialize( + JsonSerializer.Serialize(defaults)); + + Assert.NotNull(roundTrip); + Assert.True(roundTrip.ShareExceptionReports); + } + /// /// First-start regression guard: older settings payloads can /// still contain ActionStatus from a previous write. This diff --git a/src/PostIt/PostIt.Tests/YavscApiClientTests.cs b/src/PostIt/PostIt.Tests/YavscApiClientTests.cs index 2fba36b43..e0beb915e 100644 --- a/src/PostIt/PostIt.Tests/YavscApiClientTests.cs +++ b/src/PostIt/PostIt.Tests/YavscApiClientTests.cs @@ -19,6 +19,51 @@ namespace PostIt.Tests; [Trait("Category", "non-reg")] public class YavscApiClientTests { + [Fact] + public async Task Exception_reports_are_sent_only_after_local_opt_in() + { + using var apiServer = new StubApiServer(); + await apiServer.StartAsync(); + var tokensPath = TokensPath(); + try + { + var settings = new Settings + { + ApiUrl = apiServer.BaseUrl + "/api/v1/", + ShareExceptionReports = true, + Authentication = new AuthenticationSettings + { + Authority = "https://example.test/" + } + }; + settings.Load(); + var store = new TokenStore(tokensPath); + store.Save(new RefreshTokenRecord( + "access", "refresh", DateTimeOffset.UtcNow.AddMinutes(5))); + await using var client = new YavscApiClient(settings, store); + Assert.True(settings.ShareExceptionReports); + Assert.True(client.HasValidSession); + + var reportWasSent = await client.ReportExceptionAsync( + new InvalidOperationException("Messaging service unavailable"), + "PostIt.Android.Chat", + TestContext.Current.CancellationToken); + Assert.True(reportWasSent, $"share={settings.ShareExceptionReports}; session={client.HasValidSession}"); + Assert.Equal(1, apiServer.RequestCount); + + settings.ShareExceptionReports = false; + Assert.False(await client.ReportExceptionAsync( + new InvalidOperationException("Do not send"), + "PostIt.Android.Chat", + TestContext.Current.CancellationToken)); + Assert.Equal(1, apiServer.RequestCount); + } + finally + { + if (File.Exists(tokensPath)) File.Delete(tokensPath); + } + } + [Theory] [InlineData(false)] [InlineData(true)] diff --git a/src/PostIt/PostIt/App.axaml.cs b/src/PostIt/PostIt/App.axaml.cs index 1e970c2ba..68e50a581 100644 --- a/src/PostIt/PostIt/App.axaml.cs +++ b/src/PostIt/PostIt/App.axaml.cs @@ -23,6 +23,7 @@ namespace PostIt; public partial class App : Application, ILiveView, IVMPusherApp { public static bool LiveMode { get; private set; } + private static bool _exceptionHandlersRegistered; private Task? _bootTask; private bool _sessionNavigationConfigured; public static string? CliConfigFileSpecification { get; private set; } @@ -52,7 +53,14 @@ public partial class App : Application, ILiveView, IVMPusherApp this.ServiceProvider = Platform.CreateServiceProvider?.Invoke() ?? new ServiceCollection().BuildPostItServices(); var settings = ServiceProvider.GetRequiredService(); - ServiceProvider.GetRequiredService().StartSessionMaintenance(); + var api = ServiceProvider.GetRequiredService(); + api.StartSessionMaintenance(); + if (!_exceptionHandlersRegistered) + { + AppDomain.CurrentDomain.UnhandledException += OnUnhandledException; + TaskScheduler.UnobservedTaskException += OnUnobservedTaskException; + _exceptionHandlersRegistered = true; + } if (!LiveMode) { @@ -115,6 +123,20 @@ public partial class App : Application, ILiveView, IVMPusherApp base.OnFrameworkInitializationCompleted(); } + private static void OnUnhandledException(object? sender, UnhandledExceptionEventArgs args) + { + if (args.ExceptionObject is Exception exception && Current is App app) + app.ServiceProvider?.GetService() + ?.QueueExceptionReport(exception, "PostIt"); + } + + private static void OnUnobservedTaskException(object? sender, UnobservedTaskExceptionEventArgs args) + { + if (Current is App app) + app.ServiceProvider?.GetService() + ?.QueueExceptionReport(args.Exception, "PostIt"); + } + private bool IsProduction() { #if DEBUG diff --git a/src/PostIt/PostIt/Controls/StatusBar.axaml b/src/PostIt/PostIt/Controls/StatusBar.axaml deleted file mode 100644 index 755ff7d3e..000000000 --- a/src/PostIt/PostIt/Controls/StatusBar.axaml +++ /dev/null @@ -1,28 +0,0 @@ - - - - - -